workflow: Enable Kconfig and sysbuild Kconfig compliance checks by nordicjm · Pull Request #23060 · nrfconnect/sdk-nrf

nordicjm · 2025-07-01T08:25:05Z

Also fixes a lot of Kconfig errors

NordicBuilder · 2025-07-01T08:28:27Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 56

Inputs:

Sources:

sdk-nrf: PR head: fa1d3a988edb95f1981480f22da8b613594a6672

more details

sdk-nrf:

PR head: fa1d3a988edb95f1981480f22da8b613594a6672
merge base: 1a8fae0633f6019203ca1de9e75ad5a95821046d
target head (main): 1a8fae0633f6019203ca1de9e75ad5a95821046d
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (83)

.github
│  ├── workflows
│  │  │ compliance.yml
.gitignore
boards
│  ├── nordic
│  │  ├── nrf52820dongle
│  │  │  │ nrf52820dongle_nrf52820_defconfig
│  │  ├── nrf52833dongle
│  │  │  │ nrf52833dongle_nrf52833_defconfig
│  │  ├── thingy91
│  │  │  │ thingy91_nrf52840_defconfig
│  │  ├── thingy91x
│  │  │  ├── thingy91x_nrf5340_cpuapp_defconfig
│  │  │  ├── thingy91x_nrf5340_cpuapp_ns_defconfig
│  │  │  │ thingy91x_nrf5340_cpunet_defconfig
doc
│  ├── kconfig
│  │  │ conf.py
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── config_and_build
│  │  │  │  ├── sysbuild
│  │  │  │  │  │ sysbuild_images.rst
│  │  ├── security
│  │  │  ├── crypto
│  │  │  │  │ crypto_supported_features.rst
│  │  ├── templates
│  │  │  ├── application_README.rst
│  │  │  │ sample_README.rst
drivers
│  ├── flash
│  │  │ Kconfig
│  ├── mpsl
│  │  ├── flash_sync
│  │  │  │ Kconfig
│  ├── serial
│  │  │ Kconfig.nrf_sw_lpuart
include
│  ├── util
│  │  │ util_macro.h
lib
│  ├── bin
│  │  ├── lwm2m_carrier
│  │  │  │ Kconfig
│  ├── dk_buttons_and_leds
│  │  │ Kconfig
│  ├── edge_impulse
│  │  │ Kconfig
│  ├── fprotect
│  │  │ Kconfig
│  ├── hw_unique_key
│  │  │ Kconfig
│  ├── identity_key
│  │  │ Kconfig
│  ├── lte_link_control
│  │  │ Kconfig
│  ├── modem_attest_token
│  │  │ Kconfig
│  ├── ram_pwrdn
│  │  │ Kconfig
│  ├── wave_gen
│  │  │ Kconfig
modules
│  │ modules.cmake
samples
│  ├── Kconfig
│  ├── nrf5340
│  │  ├── extxip_smp_svr
│  │  │  │ README.rst
scripts
│  ├── partition_manager
│  │  │ partition_manager.rst
│  ├── tests
│  │  │ partition_manager_test.py
subsys
│  ├── app_event_manager
│  │  │ Kconfig
│  ├── audio_module
│  │  │ Kconfig
│  ├── bluetooth
│  │  ├── Kconfig.discovery
│  │  ├── Kconfig.pool
│  │  ├── controller
│  │  │  │ Kconfig
│  │  ├── mesh
│  │  │  ├── Kconfig.dk_prov
│  │  │  │ Kconfig.sensor
│  │  ├── services
│  │  │  ├── cgms
│  │  │  │  │ Kconfig.cgms
│  │  │  ├── fast_pair
│  │  │  │  ├── adv_manager
│  │  │  │  │  │ Kconfig
│  │  │  │  ├── fmdn
│  │  │  │  │  │ Kconfig
│  │  │  │  ├── fp_storage
│  │  │  │  │  │ Kconfig.fp_storage
│  │  │  ├── wifi_prov
│  │  │  │  │ Kconfig.wifi_prov
│  ├── bootloader
│  │  ├── Kconfig
│  │  ├── bl_validation
│  │  │  │ Kconfig
│  ├── caf
│  │  ├── events
│  │  │  ├── Kconfig
│  │  │  ├── Kconfig.factory_reset_event
│  │  │  ├── Kconfig.force_power_down_event
│  │  │  ├── Kconfig.keep_alive_event
│  │  │  ├── Kconfig.module_state_event
│  │  │  │ Kconfig.sensor_event
│  │  ├── modules
│  │  │  ├── Kconfig.ble_adv
│  │  │  ├── Kconfig.ble_bond
│  │  │  ├── Kconfig.ble_state
│  │  │  ├── Kconfig.factory_reset_request
│  │  │  ├── Kconfig.power_manager
│  │  │  │ Kconfig.settings_loader
│  ├── debug
│  │  ├── cpu_load
│  │  │  │ Kconfig
│  │  ├── etb_trace
│  │  │  │ Kconfig
│  │  ├── ppi_trace
│  │  │  │ Kconfig
│  ├── dult
│  │  │ Kconfig
│  ├── mpsl
│  │  ├── clock_ctrl
│  │  │  │ Kconfig
│  ├── net
│  │  ├── lib
│  │  │  ├── download_client
│  │  │  │  │ Kconfig
│  │  │  ├── fota_download
│  │  │  │  │ Kconfig
│  │  │  ├── lwm2m_client_utils
│  │  │  │  │ Kconfig
│  │  │  ├── nrf70_fw_ext
│  │  │  │  │ Kconfig
│  │  │  ├── nrf_cloud
│  │  │  │  ├── Kconfig
│  │  │  │  ├── Kconfig.nrf_cloud_coap
│  │  │  │  ├── Kconfig.nrf_cloud_fota
│  │  │  │  ├── Kconfig.nrf_cloud_location
│  │  │  │  ├── Kconfig.nrf_cloud_mqtt
│  │  │  │  │ Kconfig.nrf_cloud_shadow_info
│  ├── nrf_profiler
│  │  │ Kconfig
│  ├── nrf_security
│  │  ├── Kconfig
│  │  ├── Kconfig.legacy
│  │  ├── Kconfig.psa
│  │  ├── Kconfig.tls
│  │  ├── src
│  │  │  ├── drivers
│  │  │  │  │ Kconfig
│  ├── uart_async_adapter
│  │  │ Kconfig
sysbuild
│  │ Kconfig.wifi
tests
│  ├── crypto
│  │  ├── test_cases
│  │  │  │ test_ecdh.c
zephyr
│  │ module.yml

Outputs:

Toolchain

Version: a7529a11f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:a7529a11f4_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
❌ Integration tests
- ✅ test-sdk-audio
- ❌ desktop52_verification
- ✅ test-fw-nrfconnect-apps
- ✅ test-fw-nrfconnect-ble_mesh
- ✅ test-fw-nrfconnect-ble_samples
- ❌ test-fw-nrfconnect-chip
- ✅ test-fw-nrfconnect-nfc
- ✅ test-fw-nrfconnect-nrf-iot_cloud
- ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_samples
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m
- ❌ test-fw-nrfconnect-nrf-iot_thingy91
- ✅ test-fw-nrfconnect-nrf_crypto
- ❌ test-fw-nrfconnect-proprietary_esb
- ✅ test-fw-nrfconnect-rpc
- ✅ test-fw-nrfconnect-rs
- ✅ test-fw-nrfconnect-fem
- ✅ test-fw-nrfconnect-tfm
- ✅ test-fw-nrfconnect-thread-main
- ✅ test-sdk-find-my
- ❌ test-fw-nrfconnect-nrf_lrcs_mosh
- ❌ test-fw-nrfconnect-nrf_lrcs_positioning
- ❌ test-sdk-wifi
- ✅ test-low-level
- ✅ test-sdk-pmic-samples
- ✅ test-sdk-mcuboot
- ✅ test-sdk-dfu
- ✅ test-fw-nrfconnect-ps-main
- ✅ test-secdom-samples-public
- ⚠️ test_ble_nrf_config
- ⚠️ test-fw-nrfconnect-nrf_lrcs_mosh
- ⚠️ test-fw-nrfconnect-nrf_lrcs_positioning

Note: This message is automatically posted and updated by the CI

tejlmand

Adds a Kconfig that, when enabled, will hide the Kconfig tree of NCS

This doesn't seem to be what this PR is doing 😛

NordicBuilder · 2025-07-04T10:03:48Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

github-actions · 2025-07-04T10:29:56Z

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-23060/nrf/app_dev/config_and_build/sysbuild/sysbuild_images.html
https://ncsdoc.z6.web.core.windows.net/PR-23060/nrf/security/crypto/crypto_supported_features.html
https://ncsdoc.z6.web.core.windows.net/PR-23060/nrf/templates/application_README.html
https://ncsdoc.z6.web.core.windows.net/PR-23060/nrf/templates/sample_README.html
https://ncsdoc.z6.web.core.windows.net/PR-23060/nrf/samples/nrf5340/extxip_smp_svr/README.html
https://ncsdoc.z6.web.core.windows.net/PR-23060/nrf/scripts/partition_manager/partition_manager.html

MarekPieta

Changes to our files look good. Added a few minor comments

MarekPieta · 2025-09-01T13:13:45Z

Suggested change

bool "Detect Unwanted Location Trackers (DULT) support in FMDN"

bool "Detecting Unwanted Location Trackers (DULT) support in FMDN"

See https://datatracker.ietf.org/group/dult/about/ for reference

MarekPieta · 2025-09-01T13:14:17Z

Suggested change

##

#

greg-fer · 2025-09-01T13:49:21Z

Thanks for catching this.

Fixes capitalisation of comments Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

tejlmand · 2025-10-03T08:59:04Z

@@ -84,28 +84,28 @@ config APP_EVENT_MANAGER_PROVIDE_EVENT_SIZE
 	  and should be enabled only if such an information is required.

 config APP_EVENT_MANAGER_POSTINIT_HOOK
-	bool "Enable postinit hook"
+	bool "Postinit hook"


Isn't Post init more correct ?

Suggested change

bool "Postinit hook"

bool "Post init hook"

tejlmand · 2025-10-03T09:02:08Z

@@ -198,14 +198,14 @@ config MBEDTLS_SSL_DTLS_ANTI_REPLAY
 	  See mbedtls_ssl_conf_dtls_anti_replay() for details.

 config MBEDTLS_SSL_DTLS_HELLO_VERIFY
-	bool "Enable support for HellyVerifyRequiest on DTLS servers"
+	bool "HellyVerifyRequiest on DTLS servers"


Helly ? Requiest ?

Suggested change

bool "HellyVerifyRequiest on DTLS servers"

bool "HelloVerifyRequest on DTLS servers"

This text is completely superfluous and should not have been added Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Uses a name which is already in the allow list Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Uses config names that are already in the allow list Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Fixes an invalid Kconfig name Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

These files should not be added to git, they are generated by compliance check scripts Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Adds the folders for these locations to the zephyr module file Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Allows for modules to override the NCS Kconfig root Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Allows for modules to override the NCS Sysbuild Kconfig root Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

This text is completely superfluous and should not have been added Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Enables Kconfig and sysbuild Kconfig compliance checks Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Fixes a Kconfig name Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Replaces a dummy variable with one in the undef list Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Fixes some wrong Kconfig usage which missed wildcard characters Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Adds ZEPHYR_NRF_KCONFIG and SYSBUILD_NRF_KCONFIG variables Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

Removes a Kconfig check that does not exist Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

tejlmand

Re-approved

nordicjm requested a review from a team as a code owner July 1, 2025 08:25

github-actions Bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 1, 2025

nordicjm requested a review from a team July 1, 2025 09:54

nordicjm removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 1, 2025

nordicjm force-pushed the hideoptions branch from 93214a3 to 3b049ea Compare July 2, 2025 10:49

github-actions Bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 2, 2025

nordicjm removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 2, 2025

michalek-no approved these changes Jul 3, 2025

View reviewed changes

de-nordic approved these changes Jul 3, 2025

View reviewed changes

nordicjm force-pushed the hideoptions branch from 3b049ea to 2f0fccb Compare July 3, 2025 12:20

github-actions Bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 3, 2025

tejlmand approved these changes Jul 3, 2025

View reviewed changes

nordicjm force-pushed the hideoptions branch 2 times, most recently from 0625cd6 to e4d58b8 Compare July 4, 2025 10:02

nordicjm requested review from a team as code owners July 4, 2025 10:02

github-actions Bot added the manifest label Jul 4, 2025

NordicBuilder added manifest-zephyr DNM labels Jul 4, 2025

nordicjm force-pushed the hideoptions branch from e4d58b8 to 08828d0 Compare July 4, 2025 10:04

nordicjm force-pushed the hideoptions branch from 08828d0 to cd1db86 Compare July 4, 2025 11:05

github-actions Bot added the ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. label Jul 4, 2025

nordicjm force-pushed the hideoptions branch 3 times, most recently from 0e75ac4 to ae10632 Compare July 4, 2025 11:35

tejlmand approved these changes Jul 4, 2025

View reviewed changes

nordicjm force-pushed the hideoptions branch from ae10632 to b48b895 Compare July 4, 2025 13:39

MarekPieta approved these changes Sep 1, 2025

View reviewed changes

greg-fer reviewed Sep 1, 2025

View reviewed changes

Comment thread doc/nrf/security/crypto/crypto_supported_features.rst Outdated

Copy link
Copy Markdown

Contributor

greg-fer Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

greg-fer approved these changes Sep 1, 2025

View reviewed changes

nordicjm force-pushed the hideoptions branch from 35966fb to b78d214 Compare September 2, 2025 11:12

nordicjm requested a review from lemrey September 2, 2025 11:12

nordicjm force-pushed the hideoptions branch 5 times, most recently from f54c73c to 205b3bf Compare September 16, 2025 07:47

FrancescoSer approved these changes Sep 29, 2025

View reviewed changes

NordicBuilder mentioned this pull request Oct 3, 2025

workflow: compliance: Use additional compliance checks nrfconnect/sdk-nrf-bm#410

Merged

boards: nordic: Fix comments

d0f9820

Fixes capitalisation of comments Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

tejlmand reviewed Oct 3, 2025

View reviewed changes

nordicjm added 15 commits October 3, 2025 10:06

kconfig: Remove usage of enable in prompts

cb5bf52

This text is completely superfluous and should not have been added Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

doc: nrf: templates: Use FOO for sample Kconfig

b40b1d8

Uses a name which is already in the allow list Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

scripts: tests: partition_manager: Use other dummy config names

c8eae5b

Uses config names that are already in the allow list Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

doc: nrf: security: crypto: Fix Kconfig name

b872ec1

Fixes an invalid Kconfig name Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

gitignore: Add compliance files to ignore list

0623f84

These files should not be added to git, they are generated by compliance check scripts Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

zephyr: Add samples and test folders to module

dc19749

Adds the folders for these locations to the zephyr module file Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

zephyr: Allow external Kconfig root

0f5d934

Allows for modules to override the NCS Kconfig root Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

zephyr: Allow external Sysbuild Kconfig root

6383f71

Allows for modules to override the NCS Sysbuild Kconfig root Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

sysbuild: kconfig: Remove usage of enable in prompts

d70dfae

This text is completely superfluous and should not have been added Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

ci: Enable Kconfig and sysbuild Kconfig checks

4eed177

Enables Kconfig and sysbuild Kconfig compliance checks Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

samples: nrf5340: extxip_smp_svr: Fix Kconfig

831631c

Fixes a Kconfig name Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

scripts: partition_manager: Fix dummy variable reference

3d4a685

Replaces a dummy variable with one in the undef list Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

doc: nrf: security: crypto: Fix wrong Kconfig usage

c67944b

Fixes some wrong Kconfig usage which missed wildcard characters Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

doc: kconfig: Add extra module paths

51135f6

Adds ZEPHYR_NRF_KCONFIG and SYSBUILD_NRF_KCONFIG variables Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

tests: crypto: test_cases: test_ecdh: Remove invalid Kconfig

fa1d3a9

Removes a Kconfig check that does not exist Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>

tejlmand approved these changes Oct 3, 2025

View reviewed changes

	bool "Detect Unwanted Location Trackers (DULT) support in FMDN"
	bool "Detecting Unwanted Location Trackers (DULT) support in FMDN"

	bool "HellyVerifyRequiest on DTLS servers"
	bool "HelloVerifyRequest on DTLS servers"

Conversation

nordicjm commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

tejlmand left a comment

Choose a reason for hiding this comment

Uh oh!

NordicBuilder commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarekPieta left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tejlmand left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

nordicjm commented Jul 1, 2025 •

edited

Loading

NordicBuilder commented Jul 1, 2025 •

edited

Loading

NordicBuilder commented Jul 4, 2025 •

edited

Loading

github-actions Bot commented Jul 4, 2025 •

edited

Loading